Remove worker log by default #9052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hash change log doesn't seem actionable by the user, so we might as well only enable it for the verbose mode.
|
This test failure doesn't look related, looks like the bazel download failed |
philwo
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
Do you see this often during a build? I agree that it's not very actionable for the end-user who only wants to build some stuff.. but if you see flapping between two worker hashes during a build, this indicates a very bad build performance issue (because workers get killed and restarted all the time).
|
I saw this for the first time today, with another build it went away so I assume it was an edge case around me switching bazel versions or doing a clean or something |
|
@philwo is this good to merge? |
|
Importing for review by philwo@. |
jin
added
team-Local-Exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hash change log doesn't seem actionable by the user, so we might as
well only enable it for the verbose mode.